Fix/speech rate pitch volume#9
Merged
Merged
Conversation
The DotNetTtsWrapper's SapiTtsClient ignores TtsOptions (Rate, Pitch, Volume). Until the wrapper fix (AACTools/dotnet-tts-wrapper PR) is published as a new NuGet version, bypass it for SAPI: - Use System.Speech.SpeechSynthesizer directly in SpeechService - Rate: mapped to synthesizer.Rate (-10..10) - Volume: set directly on synthesizer (0-100) - Pitch: via SSML <prosody pitch=...> (no native property) - Voice enumeration via SpeechSynthesizer.GetInstalledVoices() Note: 32-bit SAPI5 voices still invisible because the app runs 64-bit and System.Speech is bitness-bound. Requires a 32-bit surrogate process to resolve — tracked separately. Signed-off-by: will wade <willwade@gmail.com>
Voices now load automatically when: - Speech settings panel is first shown (no need to click Load Voices) - User changes the TTS engine dropdown Signed-off-by: will wade <willwade@gmail.com>
Fixes Rate, Pitch, and Volume for SAPI voices in the wrapper itself. Dasher-Windows still has the direct SAPI bypass which can be removed in a follow-up once the wrapper fix is verified. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue / RFC: #
Type of change
Cross-platform impact
A core goal of Dasher v6 is feature parity across frontends. Help reviewers
see the blast radius:
If checked, I have opened / updated the feature matrix
(
website/src/data/feature-status.yaml) — linked PR: #(or confirmed this is genuinely platform-specific-only)
If checked, an RFC (
governance/rfcs) is linked: #Definition of Done
git commit -s